Add skipSuperCoding Codable Options
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `CodableOptions` to allow customization of the `@Codable` macro. Update the macro to accept options, enabling users to skip super encode/decode calls when the superclass does not conform to `Codable`. Refactor related methods to utilize the new options, enhancing flexibility in code generation.
Update the inheritance clause logic in CodableMacro to ensure that superclass coding is not skipped when the `skipSuperCoding` option is not present. This change enhances the handling of inheritance for Codable types, ensuring that all relevant properties are encoded correctly.
Add tests for the `@Encodable`, `@Decodable`, and `@Codable` macros with the `.skipSuperCoding` option. These tests verify that the macros correctly expand to the expected Swift code, ensuring that the generated classes handle encoding and decoding without inheriting properties from superclasses. This enhances the test coverage for the Codable macros and ensures their correct functionality in various scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the
@Codablemacro by adding a new feature calledCodableOptions, which allows for customizable behavior when encoding and decoding types.CodableOptions Implementation: A new
CodableOptionsstructure has been introduced to enable users to customize the behavior of the@Codablemacro. This includes the ability to skip superclass encode/decode calls when the superclass does not conform toCodable. This change enhances flexibility in code generation and allows for more tailored implementations of Codable types.Inheritance Logic Update: The logic within the
CodableMacrohas been updated to ensure that superclass coding is not skipped unless theskipSuperCodingoption is explicitly set. This ensures that all relevant properties from superclasses are encoded correctly, improving the handling of inheritance in Codable types.Comprehensive Testing: New tests have been added to validate the functionality of the
@Encodable,@Decodable, and@Codablemacros with the.skipSuperCodingoption. These tests ensure that the macros expand correctly to the expected Swift code and that the generated classes handle encoding and decoding appropriately, even when not inheriting properties from superclasses. This enhances the overall test coverage for the Codable macros.These changes aim to improve the usability and reliability of the Codable macros, making them more adaptable to various coding scenarios.